Skip to content

RUM-9655: Fix semantics of ExecutorService.submit vs Executor.execute usage#2616

Merged
0xnm merged 1 commit into
developfrom
nogorodnikov/rum-9655/fix-semantincs-of-executorservice-submit-vs-executor-execute-usage
Apr 24, 2025
Merged

RUM-9655: Fix semantics of ExecutorService.submit vs Executor.execute usage#2616
0xnm merged 1 commit into
developfrom
nogorodnikov/rum-9655/fix-semantincs-of-executorservice-submit-vs-executor-execute-usage

Conversation

@0xnm

@0xnm 0xnm commented Apr 24, 2025

Copy link
Copy Markdown
Member

What does this PR do?

We are using ExecutorService.submit(): Future<?> in some places where Executor.execute(): Unit is enough, because we don’t use return value. This PR switches to Executor.execute(): Unit usage where possible to explicitly indicate that we don't need return value.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm
0xnm requested review from a team as code owners April 24, 2025 09:18
@codecov-commenter

codecov-commenter commented Apr 24, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 94.11765% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 69.95%. Comparing base (ca0160c) to head (77ab677).
⚠️ Report is 2138 commits behind head on develop.

Files with missing lines Patch % Lines
.../android/rum/internal/monitor/DatadogRumMonitor.kt 66.67% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #2616      +/-   ##
===========================================
+ Coverage    69.94%   69.95%   +0.02%     
===========================================
  Files          820      820              
  Lines        30554    30554              
  Branches      5130     5130              
===========================================
+ Hits         21368    21373       +5     
- Misses        7746     7748       +2     
+ Partials      1440     1433       -7
Files with missing lines Coverage Δ
...n/com/datadog/android/core/internal/CoreFeature.kt 87.35% <100.00%> (ø)
...n/com/datadog/android/core/internal/DatadogCore.kt 82.27% <100.00%> (ø)
...droid/core/internal/persistence/AbstractStorage.kt 100.00% <100.00%> (ø)
...d/core/internal/persistence/ConsentAwareStorage.kt 96.04% <100.00%> (ø)
...ence/file/advanced/ConsentAwareFileOrchestrator.kt 93.75% <100.00%> (ø)
...ernal/persistence/file/advanced/ScheduledWriter.kt 100.00% <100.00%> (ø)
...dog/android/ndk/internal/DatadogNdkCrashHandler.kt 82.25% <100.00%> (ø)
...lin/com/datadog/android/rum/internal/RumFeature.kt 92.29% <100.00%> (+0.29%) ⬆️
...roid/sessionreplay/internal/utils/DrawableUtils.kt 96.10% <100.00%> (ø)
.../android/rum/internal/monitor/DatadogRumMonitor.kt 85.31% <66.67%> (ø)

... and 25 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@0xnm
0xnm merged commit c5b619f into develop Apr 24, 2025
@0xnm
0xnm deleted the nogorodnikov/rum-9655/fix-semantincs-of-executorservice-submit-vs-executor-execute-usage branch April 24, 2025 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ambushwork ambushwork ambushwork approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@0xnm @codecov-commenter @ambushwork