Skip to content

Minor improvements#2609

Merged
0xnm merged 1 commit into
developfrom
nogorodnikov/minor-improvements-180425
Apr 22, 2025
Merged

Minor improvements#2609
0xnm merged 1 commit into
developfrom
nogorodnikov/minor-improvements-180425

Conversation

@0xnm

@0xnm 0xnm commented Apr 18, 2025

Copy link
Copy Markdown
Member

What does this PR do?

This PR brings 2 main changes:

  • RUM application ID in the Session Replay Resource Write pipeline is resolved now from DatadogContext when it is time to write resource event
  • var changed to val where possible

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm
0xnm requested review from a team as code owners April 18, 2025 14:34
@0xnm
0xnm force-pushed the nogorodnikov/minor-improvements-180425 branch from 9cd4f4b to cb10aa0 Compare April 18, 2025 14:36
@codecov-commenter

codecov-commenter commented Apr 18, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 91.30435% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.00%. Comparing base (dfad051) to head (cb10aa0).
⚠️ Report is 2151 commits behind head on develop.

Files with missing lines Patch % Lines
.../android/rum/internal/domain/scope/RumViewScope.kt 66.67% 0 Missing and 2 partials ⚠️
...y/internal/storage/SessionReplayResourcesWriter.kt 81.82% 0 Missing and 2 partials ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #2609      +/-   ##
===========================================
+ Coverage    69.96%   70.00%   +0.04%     
===========================================
  Files          819      819              
  Lines        30556    30543      -13     
  Branches      5120     5120              
===========================================
+ Hits         21378    21381       +3     
+ Misses        7735     7734       -1     
+ Partials      1443     1428      -15
Files with missing lines Coverage Δ
...al/persistence/file/batch/BatchFileOrchestrator.kt 94.97% <100.00%> (+1.26%) ⬆️
...ndroid/rum/internal/domain/scope/RumActionScope.kt 95.65% <100.00%> (-1.63%) ⬇️
.../android/rum/internal/metric/SessionEndedMetric.kt 94.79% <100.00%> (+1.04%) ⬆️
...ric/networksettled/NetworkSettledMetricResolver.kt 94.20% <100.00%> (ø)
...android/rum/internal/vitals/VitalReaderRunnable.kt 100.00% <100.00%> (ø)
...oid/sessionreplay/internal/SessionReplayFeature.kt 98.75% <100.00%> (ø)
...sionreplay/internal/SessionReplayRecordCallback.kt 100.00% <100.00%> (ø)
...ssionreplay/internal/async/NoopDataQueueHandler.kt 0.00% <ø> (ø)
...nreplay/internal/async/RecordedDataQueueHandler.kt 95.24% <100.00%> (-0.06%) ⬇️
...ay/internal/async/ResourceRecordedDataQueueItem.kt 100.00% <ø> (ø)
... and 12 more

... and 31 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@0xnm
0xnm merged commit 99a63a5 into develop Apr 22, 2025
@0xnm
0xnm deleted the nogorodnikov/minor-improvements-180425 branch April 22, 2025 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ambushwork ambushwork ambushwork approved these changes
@jonathanmos jonathanmos jonathanmos approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@0xnm @codecov-commenter @ambushwork @jonathanmos