RUM-9426: Cover IndexOutOfBounds in DrawableUtils#2604
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2604 +/- ##
===========================================
+ Coverage 70.17% 70.20% +0.02%
===========================================
Files 812 812
Lines 30404 30408 +4
Branches 5088 5088
===========================================
+ Hits 21335 21345 +10
+ Misses 7652 7641 -11
- Partials 1417 1422 +5
🚀 New features to boost your workflow:
|
jonathanmos
force-pushed
the
jmoskovich/rum-9426/catch-indexoutofbounds
branch
from
April 16, 2025 12:14
98bf31e to
fa70dce
Compare
jonathanmos
marked this pull request as ready for review
April 16, 2025 13:47
0xnm
approved these changes
Apr 16, 2025
aleksandr-gringauz
approved these changes
Apr 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Catch
IndexOutOfBoundsexceptions inDrawableUtilsMotivation
#2599
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)