Revert "Remove shared ThreadLocal scopes"#2603
Merged
Merged
Conversation
0xnm
previously approved these changes
Apr 15, 2025
jonathanmos
previously approved these changes
Apr 15, 2025
xgouchet
force-pushed
the
xgouchet/revert_shared_scopes
branch
from
April 16, 2025 09:52
7e44a34 to
091f38b
Compare
This reverts commit 32afc41.
xgouchet
force-pushed
the
xgouchet/revert_shared_scopes
branch
from
April 16, 2025 09:53
091f38b to
678f10b
Compare
0xnm
approved these changes
Apr 16, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2603 +/- ##
===========================================
+ Coverage 70.17% 70.20% +0.03%
===========================================
Files 812 812
Lines 30404 30404
Branches 5088 5088
===========================================
+ Hits 21335 21345 +10
- Misses 7652 7658 +6
+ Partials 1417 1401 -16
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 32afc41.
What does this PR do?
The original commit attempted to allow using the tracer in a kotlin coroutine context, but ended up leading to possible memory leaks. Before we write a better integration with couroutines, we revert this to prevent the memory leak