RUM-8366 propagate session id in baggage header#2602
Merged
Conversation
0xnm
reviewed
Apr 15, 2025
| tags.append(RUM_SESSION_ID_TAG_KEY); | ||
| tags.append('='); | ||
| tags.append(sessionId); | ||
| carrier.put(BAGGAGE_KEY, RUM_SESSION_ID_BAGGAGE_KEY + '='+sessionId); |
Member
There was a problem hiding this comment.
question: we already have OT_BAGGAGE_PREFIX (ot-baggage-) here, which is used with a particular baggage item key.
won't we have any issues with having ot-baggage-xxx and baggage at the same time at the same time?
Contributor
Author
There was a problem hiding this comment.
Those headers will be independant, one of them uses the opentelemetry format, while the latter uses the W3C recommended format, ensuring it'll be propagated throughout the trace in the backend.
| tags.append(RUM_SESSION_ID_TAG_KEY); | ||
| tags.append('='); | ||
| tags.append(sessionId); | ||
| carrier.put(BAGGAGE_KEY, RUM_SESSION_ID_BAGGAGE_KEY + '='+sessionId); |
Member
There was a problem hiding this comment.
do we need to have a similar change for the com.datadog.trace.core.propagation.DatadogHttpCodec, etc.?
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #2602 +/- ##
===========================================
+ Coverage 69.98% 70.02% +0.04%
===========================================
Files 819 819
Lines 30579 30576 -3
Branches 5121 5121
===========================================
+ Hits 21399 21408 +9
- Misses 7740 7743 +3
+ Partials 1440 1425 -15
🚀 New features to boost your workflow:
|
xgouchet
force-pushed
the
xgouchet/RUM-8366/propagation_header
branch
from
April 15, 2025 11:55
4cc134e to
5ff9ef7
Compare
jonathanmos
previously approved these changes
Apr 16, 2025
0xnm
previously approved these changes
Apr 16, 2025
xgouchet
force-pushed
the
xgouchet/RUM-8366/propagation_header
branch
from
April 17, 2025 07:06
5ff9ef7 to
1384d4a
Compare
xgouchet
force-pushed
the
xgouchet/RUM-8366/propagation_header
branch
from
April 17, 2025 10:02
1384d4a to
9290c56
Compare
0xnm
approved these changes
Apr 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Update the header used to propagate the RUM session ID when tracing