RUM-9427: Add telemetry for compose instrumentation functions#2601
Merged
ambushwork merged 1 commit intoApr 16, 2025
Merged
Conversation
ambushwork
force-pushed
the
yl/kcp/add-instrumentation-telemetry
branch
2 times, most recently
from
April 15, 2025 09:06
e1cd546 to
1899309
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## feature/actions-tracking #2601 +/- ##
============================================================
- Coverage 70.11% 70.07% -0.04%
============================================================
Files 810 811 +1
Lines 30332 30380 +48
Branches 5076 5085 +9
============================================================
+ Hits 21266 21287 +21
- Misses 7647 7683 +36
+ Partials 1419 1410 -9
🚀 New features to boost your workflow:
|
ambushwork
marked this pull request as ready for review
April 15, 2025 13:30
0xnm
reviewed
Apr 15, 2025
ambushwork
force-pushed
the
yl/kcp/add-instrumentation-telemetry
branch
2 times, most recently
from
April 15, 2025 15:48
43e176d to
d888f0b
Compare
0xnm
previously approved these changes
Apr 15, 2025
| level = InternalLogger.Level.INFO, | ||
| target = InternalLogger.Target.TELEMETRY, | ||
| messageBuilder = { message }, | ||
| onlyOnce = true, |
Member
There was a problem hiding this comment.
should we sample sendTelemetry call? even though we have onlyOnce, it can still give us a lot of traffic.
Member
Author
There was a problem hiding this comment.
you mean give an additional sample rate on top of Rum telemetry sample rate?
Member
There was a problem hiding this comment.
yes, since here it will be invoked on every usage of the component, potentially, so it may still have a big volume.
ambushwork
force-pushed
the
yl/kcp/add-instrumentation-telemetry
branch
from
April 16, 2025 08:02
d888f0b to
4940e2c
Compare
3 tasks
0xnm
approved these changes
Apr 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Before releasing the compose auto instrumentation, we need to add telemetry about the usage of auto instrumentation.
Since it is almost impossible to add telemetry directly, the idea of this PR is to send telemetry when the instrumented function is call.
Main changes in this PR:
datadogandNavigationViewTrackingEffectwhich can be called by user manually and also instrumented by KCP automatically. NowinstrumentedDatadogandinstrumentedNavigationViewTrackingEffectinternal functions are added, and they are reserved to KCP for auto instrumentation. The public APIs stay the same.Motivation
RUM-9427
Review checklist (to be filled by reviewers)