RUM-8879: Sample telemetry for RecordedDataQueueHandler#2600
Merged
jonathanmos merged 1 commit intoApr 15, 2025
Conversation
jonathanmos
force-pushed
the
jmoskovich/rum-8879/sampling-recordeddataqueue
branch
from
April 14, 2025 11:13
a580bcc to
b575486
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2600 +/- ##
===========================================
- Coverage 70.18% 70.15% -0.03%
===========================================
Files 812 812
Lines 30399 30404 +5
Branches 5086 5088 +2
===========================================
- Hits 21335 21329 -6
- Misses 7650 7654 +4
- Partials 1414 1421 +7
🚀 New features to boost your workflow:
|
jonathanmos
marked this pull request as ready for review
April 14, 2025 13:30
jonathanmos
marked this pull request as draft
April 14, 2025 13:31
jonathanmos
force-pushed
the
jmoskovich/rum-8879/sampling-recordeddataqueue
branch
from
April 14, 2025 13:37
b575486 to
a0ac297
Compare
jonathanmos
marked this pull request as ready for review
April 14, 2025 13:44
xgouchet
approved these changes
Apr 15, 2025
0xnm
approved these changes
Apr 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Implement a 1% sampling rate on recordedDataQueueHandler telemetry messages
Motivation
Reduce the frequency of these messages
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)