Skip to content

Merge Feature/actions-tracking into develop#2598

Merged
ambushwork merged 14 commits into
developfrom
feature/actions-tracking
Apr 16, 2025
Merged

Merge Feature/actions-tracking into develop#2598
ambushwork merged 14 commits into
developfrom
feature/actions-tracking

Conversation

@ambushwork

@ambushwork ambushwork commented Apr 10, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

What does this PR do?

The end of feature development, Merging Feature/actions-tracking into develop

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

ambushwork and others added 14 commits March 28, 2025 14:10
@ambushwork
Add Compose instrumentation API for view tracking and image recording
5c62578
@ambushwork
Merge pull request #2570 from DataDog/yl/kcp/add-instrumentation-api
093f90f 
Add Compose instrumentation API for view tracking and image recording
@ambushwork
RUM-9309: Add ActionTrackingStrategy Interface to decouple find vie…
4efc5e4 
…w logic
@ambushwork
Merge pull request #2573 from DataDog/yl/track-actions/add-strategy-i…
9aa11a6 
…nterface

RUM-9309: Add `ActionTrackingStrategy` Interface to decouple find view logic
@ambushwork
RUM-9297: Add Compose actions tracking strategy API in RumConfiguration
c80f7cc
@ambushwork
Merge pull request #2575 from DataDog/yl/track-actions/add-rum-config…
4e4c289 
…-api

RUM-9297: Add Compose actions tracking strategy API in RumConfiguration
@ambushwork
Merge branch 'feature/compose-instrumentation-api' into yl/track-acti…
d7fbb5f 
…ons/merge-feature-compose-api
@ambushwork
Merge pull request #2583 from DataDog/yl/track-actions/merge-feature-…
7a03965 
…compose-api

Merge feature/compose-instrumentation api into feature/actions-tracking
@ambushwork
RUM-9298: Implement Compose actions tracking strategy
9543ce6
@ambushwork
Merge pull request #2586 from DataDog/yl/track-actions/refactor-gestu…
b97cbe1 
…re-listener

RUM-9298: Implement Compose actions tracking strategy
@ambushwork
Change TrackViews and RecordImages annotations to ComposeInstrumentation
cececcd
@ambushwork
Merge pull request #2595 from DataDog/yl/track-actions/update-annotat…
0b71747 
…ions

Change TrackViews and RecordImages annotations to ComposeInstrumentation
@ambushwork
RUM-9427: Add telemetry for compose instrumentation functions
4940e2c
@ambushwork
Merge pull request #2601 from DataDog/yl/kcp/add-instrumentation-tele…
d42c791 
…metry

RUM-9427: Add telemetry for compose instrumentation functions
@codecov-commenter

codecov-commenter commented Apr 16, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 59.70149% with 108 lines in your changes missing coverage. Please review.

Project coverage is 70.00%. Comparing base (8464f0f) to head (d42c791).
Report is 222 commits behind head on develop.

Files with missing lines Patch % Lines
...n/kotlin/com/datadog/android/compose/Navigation.kt 0.00% 28 Missing ⚠️
.../android/compose/internal/utils/LayoutNodeUtils.kt 53.66% 14 Missing and 5 partials ⚠️
.../compose/internal/ComposeActionTrackingStrategy.kt 46.88% 11 Missing and 6 partials ⚠️
.../com/datadog/android/compose/internal/Telemetry.kt 0.00% 16 Missing ⚠️
...lin/com/datadog/android/compose/DatadogModifier.kt 28.57% 10 Missing ⚠️
...instrumentation/gestures/DatadogGesturesTracker.kt 12.50% 7 Missing ⚠️
...ernal/instrumentation/gestures/GesturesListener.kt 95.24% 1 Missing and 3 partials ⚠️
...com/datadog/android/compose/RumConfigurationExt.kt 0.00% 4 Missing ⚠️
...otlin/com/datadog/android/rum/_RumInternalProxy.kt 0.00% 1 Missing ⚠️
...entation/gestures/AndroidActionTrackingStrategy.kt 95.00% 0 Missing and 1 partial ⚠️
... and 1 more
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #2598      +/-   ##
===========================================
- Coverage    70.31%   70.00%   -0.30%     
===========================================
  Files          804      811       +7     
  Lines        30196    30380     +184     
  Branches      5050     5085      +35     
===========================================
+ Hits         21230    21267      +37     
- Misses        7587     7694     +107     
- Partials      1379     1419      +40
Files with missing lines Coverage Δ
...kotlin/com/datadog/android/rum/RumConfiguration.kt 97.30% <100.00%> (+0.11%) ⬆️
...lin/com/datadog/android/rum/internal/RumFeature.kt 92.29% <100.00%> (-0.11%) ⬇️
...lin/com/datadog/android/rum/tracking/ViewTarget.kt 100.00% <100.00%> (ø)
...otlin/com/datadog/android/rum/_RumInternalProxy.kt 70.59% <0.00%> (-4.41%) ⬇️
...entation/gestures/AndroidActionTrackingStrategy.kt 95.00% <95.00%> (ø)
...internal/instrumentation/gestures/GesturesUtils.kt 85.71% <66.67%> (-5.19%) ⬇️
...ernal/instrumentation/gestures/GesturesListener.kt 94.41% <95.24%> (+0.57%) ⬆️
...com/datadog/android/compose/RumConfigurationExt.kt 0.00% <0.00%> (ø)
...instrumentation/gestures/DatadogGesturesTracker.kt 63.64% <12.50%> (-0.65%) ⬇️
...lin/com/datadog/android/compose/DatadogModifier.kt 28.57% <28.57%> (ø)
... and 4 more

... and 23 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ambushwork
ambushwork marked this pull request as ready for review April 16, 2025 13:35
@ambushwork
ambushwork requested review from a team as code owners April 16, 2025 13:35
@ambushwork
ambushwork merged commit 8507287 into develop Apr 16, 2025
@ambushwork
ambushwork deleted the feature/actions-tracking branch April 16, 2025 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xnm 0xnm 0xnm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ambushwork @codecov-commenter @0xnm