Skip to content

Merge feature/compose-instrumentation api into feature/actions-tracking#2583

Merged
ambushwork merged 3 commits into
feature/actions-trackingfrom
yl/track-actions/merge-feature-compose-api
Apr 7, 2025
Merged

Merge feature/compose-instrumentation api into feature/actions-tracking#2583
ambushwork merged 3 commits into
feature/actions-trackingfrom
yl/track-actions/merge-feature-compose-api

Conversation

@ambushwork

Copy link
Copy Markdown
Member

What does this PR do?

datadog Modifier API is necessary for compose actions tracking, so merge feature branch of the instrumentation api into feature branch of actions tracking.

NOTE: this commit has already been reviewed before.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@ambushwork
ambushwork requested review from a team as code owners April 4, 2025 15:31
@codecov-commenter

codecov-commenter commented Apr 4, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.16%. Comparing base (4e4c289) to head (d7fbb5f).

Files with missing lines Patch % Lines
...lin/com/datadog/android/compose/DatadogModifier.kt 0.00% 10 Missing ⚠️
Additional details and impacted files
@@                     Coverage Diff                      @@
##           feature/actions-tracking    #2583      +/-   ##
============================================================
- Coverage                     70.18%   70.16%   -0.02%     
============================================================
  Files                           808      809       +1     
  Lines                         30235    30245      +10     
  Branches                       5052     5053       +1     
============================================================
+ Hits                          21218    21220       +2     
- Misses                         7612     7618       +6     
- Partials                       1405     1407       +2     
Files with missing lines Coverage Δ
...lin/com/datadog/android/compose/DatadogModifier.kt 0.00% <0.00%> (ø)

... and 33 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ambushwork
ambushwork merged commit 7a03965 into feature/actions-tracking Apr 7, 2025
@ambushwork
ambushwork deleted the yl/track-actions/merge-feature-compose-api branch April 7, 2025 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants