Skip to content

[RUM-9361] fixing negative values in slow frames, adjusting telemetry#2582

Merged
satween merged 4 commits into
developfrom
tvaleev/feature/RUM-9361-negative
Apr 4, 2025
Merged

[RUM-9361] fixing negative values in slow frames, adjusting telemetry#2582
satween merged 4 commits into
developfrom
tvaleev/feature/RUM-9361-negative

Conversation

@satween

@satween satween commented Apr 4, 2025

Copy link
Copy Markdown
Contributor

What does this PR do?

  • Fixes negative value for start variable for slow frames record
  • Adds missed_count for ui slowness telemetry to see how often such events occurs
  • Adds view_duration value to align with iOS implementation

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@satween
satween requested review from a team as code owners April 4, 2025 13:45
0xnm
0xnm previously approved these changes Apr 4, 2025
View reviewed changes
Comment thread .../com/datadog/android/rum/internal/metric/slowframes/DefaultUISlownessMetricDispatcherTest.kt Outdated
var fakeSamplingRate: Float = 0f

@LongForgery(min = 1, max = 100)
var fakeViewDuration: Long = 0

@0xnm 0xnm Apr 4, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor: should we add a unit to the property name?

@codecov-commenter

codecov-commenter commented Apr 4, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 85.71429% with 2 lines in your changes missing coverage. Please review.

Project coverage is 70.20%. Comparing base (725ff74) to head (42fca1b).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
.../android/rum/internal/domain/scope/RumViewScope.kt 0.00% 0 Missing and 1 partial ⚠️
...al/metric/slowframes/UISlownessMetricDispatcher.kt 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #2582      +/-   ##
===========================================
+ Coverage    70.18%   70.20%   +0.02%     
===========================================
  Files          808      808              
  Lines        30292    30301       +9     
  Branches      5075     5077       +2     
===========================================
+ Hits         21258    21270      +12     
+ Misses        7627     7626       -1     
+ Partials      1407     1405       -2
Files with missing lines Coverage Δ
...m/internal/metric/slowframes/SlowFramesListener.kt 97.96% <100.00%> (+0.13%) ⬆️
.../android/rum/internal/domain/scope/RumViewScope.kt 94.72% <0.00%> (ø)
...al/metric/slowframes/UISlownessMetricDispatcher.kt 93.33% <87.50%> (-1.54%) ⬇️

... and 29 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@satween
satween merged commit 9acf4ba into develop Apr 4, 2025
@satween
satween deleted the tvaleev/feature/RUM-9361-negative branch April 4, 2025 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xnm 0xnm 0xnm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@satween @codecov-commenter @0xnm