RUM-9340: Fix RumAction Tap is added twice for every ACTION_UP#2579
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2579 +/- ##
===========================================
+ Coverage 70.17% 70.19% +0.01%
===========================================
Files 808 808
Lines 30300 30300
Branches 5075 5076 +1
===========================================
+ Hits 21263 21267 +4
+ Misses 7626 7624 -2
+ Partials 1411 1409 -2
🚀 New features to boost your workflow:
|
ambushwork
marked this pull request as ready for review
April 3, 2025 05:03
mariusc83
approved these changes
Apr 3, 2025
0xnm
approved these changes
Apr 4, 2025
jonathanmos
approved these changes
Apr 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Prior to this PR,
RumMonitor.addActions(RumActionType.Tap)will always be called twice for a single tap action, this is because that inGestureListenerbothonSingleTapUpandonUpare called byGesturesDetectorWrapperwhen a ACTION_UP is received. both functions will calladdActionsfor this tap.The fix is to make
onSingleTapUpreturn true, indicating that the tap is already consumed and should not be handled it again.Motivation
RUM-9340
Review checklist (to be filled by reviewers)