Skip to content

Optimize OkHttp configuration telemetry#2578

Merged
0xnm merged 1 commit into
developfrom
nogorodnikov/optimize-okhttp-configuration-telemetry
Apr 2, 2025
Merged

Optimize OkHttp configuration telemetry#2578
0xnm merged 1 commit into
developfrom
nogorodnikov/optimize-okhttp-configuration-telemetry

Conversation

@0xnm

@0xnm 0xnm commented Apr 2, 2025

Copy link
Copy Markdown
Member

What does this PR do?

We can optimize a big logic of sending OkHttp configuration telemetry by reading values directly in TelemetryEventHandler instead.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm
0xnm requested review from a team as code owners April 2, 2025 11:39
@0xnm
0xnm force-pushed the nogorodnikov/optimize-okhttp-configuration-telemetry branch from 4a78fc4 to b006aa1 Compare April 2, 2025 12:00
@codecov-commenter

codecov-commenter commented Apr 2, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.14%. Comparing base (50a8e24) to head (b006aa1).
⚠️ Report is 337 commits behind head on develop.

Files with missing lines Patch % Lines
...ndroid/telemetry/internal/TelemetryEventHandler.kt 20.00% 0 Missing and 4 partials ⚠️
...droid/internal/telemetry/InternalTelemetryEvent.kt 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #2578      +/-   ##
===========================================
- Coverage    70.17%   70.14%   -0.03%     
===========================================
  Files          808      808              
  Lines        30300    30292       -8     
  Branches      5075     5075              
===========================================
- Hits         21263    21247      -16     
- Misses        7626     7632       +6     
- Partials      1411     1413       +2
Files with missing lines Coverage Δ
...n/com/datadog/android/core/internal/DatadogCore.kt 82.27% <100.00%> (+0.41%) ⬆️
...id/okhttp/internal/trace/TracingHeaderTypeUtils.kt 20.00% <ø> (-55.00%) ⬇️
...datadog/android/okhttp/trace/TracingInterceptor.kt 75.48% <100.00%> (ø)
...droid/internal/telemetry/InternalTelemetryEvent.kt 30.00% <0.00%> (+1.88%) ⬆️
...ndroid/telemetry/internal/TelemetryEventHandler.kt 87.46% <20.00%> (-0.87%) ⬇️

... and 22 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@0xnm
0xnm merged commit 725ff74 into develop Apr 2, 2025
@0xnm
0xnm deleted the nogorodnikov/optimize-okhttp-configuration-telemetry branch April 2, 2025 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ambushwork ambushwork ambushwork approved these changes
@aleksandr-gringauz aleksandr-gringauz aleksandr-gringauz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@0xnm @codecov-commenter @ambushwork @aleksandr-gringauz