Optimize features context reads in TelemetryEventHandler#2576
Merged
0xnm merged 1 commit intoApr 2, 2025
Merged
Conversation
aleksandr-gringauz
approved these changes
Apr 2, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2576 +/- ##
========================================
Coverage 70.17% 70.17%
========================================
Files 808 808
Lines 30301 30300 -1
Branches 5073 5075 +2
========================================
Hits 21263 21263
+ Misses 7629 7625 -4
- Partials 1409 1412 +3
🚀 New features to boost your workflow:
|
0xnm
deleted the
nogorodnikov/optimize-feature-context-reads-in-telemetry-event-handler
branch
April 2, 2025 10:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
A very minor 🤏 optimization for the features context read in the
TelemetryEventHandler: it is already available in theDatadogContextobject, so there is no need to do additional queries.Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)