RUM-9297: Add Compose actions tracking strategy API in RumConfiguration#2575
Merged
ambushwork merged 1 commit intoApr 4, 2025
Merged
Conversation
ambushwork
force-pushed
the
yl/track-actions/add-rum-config-api
branch
4 times, most recently
from
April 1, 2025 15:35
4a17a14 to
cb9c390
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/actions-tracking #2575 +/- ##
============================================================
- Coverage 70.31% 70.14% -0.17%
============================================================
Files 804 808 +4
Lines 30196 30235 +39
Branches 5050 5052 +2
============================================================
- Hits 21230 21206 -24
- Misses 7587 7618 +31
- Partials 1379 1411 +32
🚀 New features to boost your workflow:
|
ambushwork
marked this pull request as ready for review
April 1, 2025 16:25
0xnm
reviewed
Apr 2, 2025
ambushwork
force-pushed
the
yl/track-actions/add-rum-config-api
branch
3 times, most recently
from
April 3, 2025 10:24
6eabf12 to
3de5964
Compare
ambushwork
force-pushed
the
yl/track-actions/add-rum-config-api
branch
from
April 3, 2025 11:10
3de5964 to
5f876ce
Compare
0xnm
reviewed
Apr 3, 2025
0xnm
left a comment
0xnm
left a comment
Member
There was a problem hiding this comment.
overall lgtm! I've added few comments and suggestions.
Comment on lines
+111
to
+112
| composeActionTrackingStrategy = composeActionsTrackingStrategy, | ||
| internalLogger = internalLogger |
Member
There was a problem hiding this comment.
do we need to use named arguments if variable name matches?
Member
Author
There was a problem hiding this comment.
Personally I prefer always adding named argument for function call, for mainly these reasons:
- avoid argument orders mistakes if some arguments have same type.
- more readable in PR on GH, especially the variable name doesn't match exactly with argument name.
- be alerted with the silent break of argument name in the function declaration.
Maybe none of these advantages apply here in this PR, but I think it's a good thing to have more in our code base, WDYT?
Member
There was a problem hiding this comment.
yes, sure, makes sense. just then maybe we can make it consistent and add all names for the remaining arguments in this function call?
Member
Author
There was a problem hiding this comment.
updated with full named arguments
ambushwork
force-pushed
the
yl/track-actions/add-rum-config-api
branch
from
April 4, 2025 08:21
5f876ce to
e8b3239
Compare
ambushwork
force-pushed
the
yl/track-actions/add-rum-config-api
branch
from
April 4, 2025 09:40
e8b3239 to
c80f7cc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add API
setComposeTrackingStrategyin RumConfiguration which allows user to addComposeActionsTrackingStategy.So that
GestureListenerwill be able to use this strategy to locate target in Jetpack Compose.Motivation
RUM-9297
Review checklist (to be filled by reviewers)