RUM-9309: Add ActionTrackingStrategy Interface to decouple find view logic#2573
Merged
ambushwork merged 1 commit intoApr 1, 2025
Merged
Conversation
ambushwork
force-pushed
the
yl/track-actions/add-strategy-interface
branch
3 times, most recently
from
March 31, 2025 15:00
f7200e8 to
74a86c6
Compare
ambushwork
marked this pull request as ready for review
March 31, 2025 15:06
ambushwork
force-pushed
the
yl/track-actions/add-strategy-interface
branch
from
March 31, 2025 15:23
74a86c6 to
ce33c49
Compare
aleksandr-gringauz
previously approved these changes
Apr 1, 2025
0xnm
previously approved these changes
Apr 1, 2025
ambushwork
force-pushed
the
yl/track-actions/add-strategy-interface
branch
2 times, most recently
from
April 1, 2025 07:47
26d59ac to
20d35be
Compare
jonathanmos
previously approved these changes
Apr 1, 2025
0xnm
previously approved these changes
Apr 1, 2025
mariusc83
previously approved these changes
Apr 1, 2025
ambushwork
dismissed stale reviews from mariusc83, 0xnm, and jonathanmos
via
April 1, 2025 08:55
019fe4c
ambushwork
force-pushed
the
yl/track-actions/add-strategy-interface
branch
from
April 1, 2025 08:55
20d35be to
019fe4c
Compare
0xnm
previously approved these changes
Apr 1, 2025
ambushwork
force-pushed
the
yl/track-actions/add-strategy-interface
branch
from
April 1, 2025 09:02
019fe4c to
4efc5e4
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## feature/actions-tracking #2573 +/- ##
============================================================
- Coverage 70.31% 70.16% -0.15%
============================================================
Files 804 806 +2
Lines 30196 30212 +16
Branches 5050 5050
============================================================
- Hits 21230 21197 -33
- Misses 7587 7610 +23
- Partials 1379 1405 +26
🚀 New features to boost your workflow:
|
0xnm
approved these changes
Apr 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Prior to this PR,
GesturesListeneris coupled with Android View framework to find a target view of user interaction, making it difficult to extend to Jetpack Compose.To make the Jetpack compose view finding possible within
GesturesListener, this PR adds an interface calledActionTrackingStrategy, and move all the Android View framework logic fromGestureListenerinto theAndroidActionTrackingStrategyimplementation. This change makesGesturesListeneragnostic about the view framework, prepares for the Compose actions tracking integrationMotivation
RUM-9309
Review checklist (to be filled by reviewers)