Skip to content

Add Compose instrumentation API for view tracking and image recording#2570

Merged
ambushwork merged 1 commit into
feature/compose-instrumentation-apifrom
yl/kcp/add-instrumentation-api
Mar 28, 2025
Merged

Add Compose instrumentation API for view tracking and image recording#2570
ambushwork merged 1 commit into
feature/compose-instrumentation-apifrom
yl/kcp/add-instrumentation-api

Conversation

@ambushwork

@ambushwork ambushwork commented Mar 27, 2025

Copy link
Copy Markdown
Member

What does this PR do?

  • Add datadog function to be instrumented by Kotlin Compiler plugin for image recordings in Jetpack Compose
  • Add annotations RecordImages and TrackViews for instrumentation annotation mode.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@ambushwork
ambushwork force-pushed the yl/kcp/add-instrumentation-api branch 2 times, most recently from e4252d9 to 6f4407f Compare March 28, 2025 11:30
@ambushwork
ambushwork marked this pull request as ready for review March 28, 2025 11:33
@ambushwork
ambushwork requested review from a team as code owners March 28, 2025 11:33
0xnm
0xnm previously approved these changes Mar 28, 2025
@codecov-commenter

codecov-commenter commented Mar 28, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 70.13%. Comparing base (f807ef6) to head (5c62578).

Files with missing lines Patch % Lines
...lin/com/datadog/android/compose/DatadogModifier.kt 0.00% 10 Missing ⚠️
Additional details and impacted files
@@                           Coverage Diff                           @@
##           feature/compose-instrumentation-api    #2570      +/-   ##
=======================================================================
- Coverage                                70.24%   70.13%   -0.11%     
=======================================================================
  Files                                      803      804       +1     
  Lines                                    30144    30154      +10     
  Branches                                  5046     5047       +1     
=======================================================================
- Hits                                     21173    21146      -27     
- Misses                                    7587     7594       +7     
- Partials                                  1384     1414      +30     
Files with missing lines Coverage Δ
...lin/com/datadog/android/compose/DatadogModifier.kt 0.00% <0.00%> (ø)

... and 32 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

jonathanmos
jonathanmos previously approved these changes Mar 28, 2025
@ambushwork
ambushwork dismissed stale reviews from jonathanmos and 0xnm via 5c62578 March 28, 2025 14:10
@ambushwork
ambushwork force-pushed the yl/kcp/add-instrumentation-api branch from 6f4407f to 5c62578 Compare March 28, 2025 14:10
@ambushwork
ambushwork requested review from 0xnm and jonathanmos March 28, 2025 14:19
@ambushwork
ambushwork merged commit 093f90f into feature/compose-instrumentation-api Mar 28, 2025
@ambushwork
ambushwork deleted the yl/kcp/add-instrumentation-api branch March 28, 2025 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants