RUM-8632: Introducing UISlownessMetricDispatcher#2567
Merged
Conversation
satween
force-pushed
the
tvaleev/feature/RUM-8632-ui_slowness-telemetry
branch
from
March 24, 2025 17:59
f16c1a7 to
d58cead
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2567 +/- ##
===========================================
+ Coverage 70.14% 70.17% +0.03%
===========================================
Files 803 804 +1
Lines 30146 30196 +50
Branches 5046 5050 +4
===========================================
+ Hits 21145 21190 +45
+ Misses 7600 7595 -5
- Partials 1401 1411 +10
🚀 New features to boost your workflow:
|
jonathanmos
previously approved these changes
Mar 25, 2025
| internal const val KEY_MAX_DURATION = "max_duration" | ||
| internal const val KEY_VIEW_MIN_DURATION = "view_min_duration" | ||
|
|
||
| internal const val KEY_FREEZED_FRAMES = "freezed_frames" |
Member
There was a problem hiding this comment.
Are we sure about the use of "freezed frames" for the plural? I think frozen frames would be more correct
Contributor
Author
There was a problem hiding this comment.
Yep, I agree. The problem that we already have "frozen" word in many places. I was trying to separate this one from the others. But probably we should stick to the correct word anyway
Contributor
Author
There was a problem hiding this comment.
We decided to remove frozen frames from the telemetry for now. We gonna add them separately
0xnm
reviewed
Mar 25, 2025
satween
force-pushed
the
tvaleev/feature/RUM-8632-ui_slowness-telemetry
branch
from
March 27, 2025 11:35
d58cead to
9151319
Compare
ambushwork
previously approved these changes
Mar 27, 2025
0xnm
previously approved these changes
Mar 28, 2025
Comment on lines
+116
to
+121
| verify(mockInternalLogger).logMetric( | ||
| argThat { invoke() == DefaultUISlownessMetricDispatcher.UI_SLOWNESS_MESSAGE }, | ||
| argThat { hasExpectedValue(1, KEY_RUM_UI_SLOWNESS, KEY_SLOW_FRAMES, KEY_IGNORED_COUNT) }, | ||
| eq(fakeSamplingRate), | ||
| eq(null) | ||
| ) |
Member
There was a problem hiding this comment.
minor: in case of the failure the error will be generic - something like the method was expected to be called with arguments matching the certain criteria, but it wasn't, and it will take some effort to understand what exactly didn't match (and in this test we are targeting the specific attribute).
We could just use arguments captor to capture attributes and assert them granularly, providing the exact message about the failure reason.
But anyway, this is just minor, I'm okay with such assertion as well.
jonathanmos
previously approved these changes
Mar 28, 2025
satween
dismissed stale reviews from jonathanmos, 0xnm, and ambushwork
via
March 28, 2025 13:12
2c29fcd
0xnm
approved these changes
Mar 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
"RUM UI Slowness" Telemetry support for UI slowness feature
See spec for more details
Review checklist (to be filled by reviewers)