Remove the possibility to read Tracer config from env and from config file#2564
Merged
0xnm merged 1 commit intoMar 24, 2025
Conversation
aleksandr-gringauz
approved these changes
Mar 21, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2564 +/- ##
===========================================
- Coverage 70.20% 70.17% -0.03%
===========================================
Files 803 803
Lines 30197 30191 -6
Branches 5060 5058 -2
===========================================
- Hits 21199 21186 -13
- Misses 7593 7605 +12
+ Partials 1405 1400 -5
🚀 New features to boost your workflow:
|
mariusc83
approved these changes
Mar 24, 2025
jonathanmos
approved these changes
Mar 24, 2025
0xnm
deleted the
nogorodnikov/remove-tracer-config-values-initialization-from-env-and-file
branch
March 24, 2025 10:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR removes the functionality of reading Tracer config from env variables and config file: both are options are not possible on Android.
It gives saves quite a good time during the Tracer initialization:
In theory, we can also remove config read from system properties (
System.getProperties), but these ones can be set from the process (unlike env variables). Unlikely that it is used by any customer, but anyway removal of this block won't give a significant gain.Review checklist (to be filled by reviewers)