Skip to content

[RUM-9154]: reverting back os version constraints to S for registerMetricsListener and unregisterMetricsListener#2558

Merged
satween merged 1 commit into
release/2.19.0from
tvaleev/RUM-9154/fix-NPE-in-metrics
Mar 20, 2025
Merged

[RUM-9154]: reverting back os version constraints to S for registerMetricsListener and unregisterMetricsListener#2558
satween merged 1 commit into
release/2.19.0from
tvaleev/RUM-9154/fix-NPE-in-metrics

Conversation

@satween

@satween satween commented Mar 19, 2025

Copy link
Copy Markdown
Contributor

What does this PR do?

  • Reverting SDK constraints for registerMetricsListener and unregisterMetricsListener to S
  • Add tests and comments to prevent this issue from happening in the future

Motivation

Issue

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@satween
satween requested review from a team as code owners March 19, 2025 16:08
@codecov-commenter

codecov-commenter commented Mar 19, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.04%. Comparing base (52d70bb) to head (bfe7e1f).
Report is 2 commits behind head on release/2.19.0.

Additional details and impacted files
@@                Coverage Diff                 @@
##           release/2.19.0    #2558      +/-   ##
==================================================
- Coverage           70.17%   70.04%   -0.13%     
==================================================
  Files                 797      797              
  Lines               30049    30049              
  Branches             5031     5031              
==================================================
- Hits                21085    21047      -38     
- Misses               7581     7597      +16     
- Partials             1383     1405      +22     
Files with missing lines Coverage Δ
...ernal/vitals/JankStatsActivityLifecycleListener.kt 71.74% <100.00%> (+0.72%) ⬆️

... and 28 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@satween
satween merged commit 530128c into release/2.19.0 Mar 20, 2025
@satween
satween deleted the tvaleev/RUM-9154/fix-NPE-in-metrics branch March 20, 2025 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants