Skip to content

[RUM-9151]: fix issue with missing freeze rate and slow frames rate#2557

Merged
satween merged 2 commits into
developfrom
tvaleev/feature/RUM-9151
Mar 19, 2025
Merged

[RUM-9151]: fix issue with missing freeze rate and slow frames rate#2557
satween merged 2 commits into
developfrom
tvaleev/feature/RUM-9151

Conversation

@satween

@satween satween commented Mar 19, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

What does this PR do?

Changes logic for ui slowness report a bit: now report is removed only when view is complete

Motivation

We have an issue with resolveReport method implementation: report was removed from the map when resolveReport is called, so in case if there are several events within the view scope - report will be sent only for the first update

Additional Notes

These changes should be part of the main feature branch PR but it was too big so I've decided to merge them separately

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@satween
satween requested review from a team as code owners March 19, 2025 14:31
0xnm
0xnm previously approved these changes Mar 19, 2025
View reviewed changes

@0xnm 0xnm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! added a few suggestions

Comment thread ...rum/src/main/kotlin/com/datadog/android/rum/internal/metric/slowframes/SlowFramesListener.kt Outdated
Comment thread ...t/kotlin/com/datadog/android/rum/internal/metric/slowframes/DefaultSlowFramesListenerTest.kt Outdated
Comment thread ...t/kotlin/com/datadog/android/rum/internal/metric/slowframes/DefaultSlowFramesListenerTest.kt Outdated
Comment thread ...t/kotlin/com/datadog/android/rum/internal/metric/slowframes/DefaultSlowFramesListenerTest.kt Outdated
@satween
satween requested a review from 0xnm March 19, 2025 16:33
@codecov-commenter

codecov-commenter commented Mar 19, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 70.16%. Comparing base (344e805) to head (37d5b8f).
Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
.../android/rum/internal/domain/scope/RumViewScope.kt 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #2557      +/-   ##
===========================================
- Coverage    70.23%   70.16%   -0.08%     
===========================================
  Files          803      803              
  Lines        30196    30197       +1     
  Branches      5059     5060       +1     
===========================================
- Hits         21207    21185      -22     
- Misses        7590     7598       +8     
- Partials      1399     1414      +15
Files with missing lines Coverage Δ
...m/internal/metric/slowframes/SlowFramesListener.kt 97.44% <100.00%> (+0.07%) ⬆️
.../android/rum/internal/domain/scope/RumViewScope.kt 93.88% <0.00%> (-0.60%) ⬇️

... and 28 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@satween
satween merged commit 86a6b46 into develop Mar 19, 2025
@satween
satween deleted the tvaleev/feature/RUM-9151 branch March 19, 2025 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xnm 0xnm 0xnm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@satween @codecov-commenter @0xnm