RUM-8041: Add telemetry for pending batch files#2548
Merged
Conversation
jonathanmos
force-pushed
the
jmoskovich/rum-8041/pending-batches
branch
from
March 16, 2025 10:02
6dfcdbf to
504c1c0
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2548 +/- ##
===========================================
- Coverage 70.06% 70.03% -0.03%
===========================================
Files 797 797
Lines 30027 30038 +11
Branches 5027 5027
===========================================
Hits 21036 21036
- Misses 7593 7600 +7
- Partials 1398 1402 +4
🚀 New features to boost your workflow:
|
jonathanmos
marked this pull request as ready for review
March 17, 2025 09:38
ambushwork
previously approved these changes
Mar 17, 2025
0xnm
previously approved these changes
Mar 18, 2025
jonathanmos
force-pushed
the
jmoskovich/rum-8041/pending-batches
branch
from
March 18, 2025 11:45
504c1c0 to
a1c1e4c
Compare
ambushwork
approved these changes
Mar 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds to
batch deletedevents the number of pending batch files in the directory at the time the metric was sent.Motivation
Additional telemetry to increase transparency.
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)