RUM-9021 use session consistent trace sampling#2544
Merged
Conversation
0xnm
previously approved these changes
Mar 14, 2025
| constructor(Float) | ||
| constructor(Double) | ||
| fun okhttp3.Request.Builder.parentSpan(io.opentracing.Span): okhttp3.Request.Builder | ||
| object com.datadog.android.okhttp.trace.SpanSamplingIdProvider |
Member
There was a problem hiding this comment.
this file probably needs to be updated, because SpanSamplingIdProvider is internal, so it shouldn't be here
jonathanmos
previously approved these changes
Mar 17, 2025
xgouchet
force-pushed
the
xgouchet/RUM-9021/consistent_trace_sampling
branch
from
March 17, 2025 09:15
13a0a3e to
9ad9971
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/v3 #2544 +/- ##
==============================================
- Coverage 70.10% 70.02% -0.08%
==============================================
Files 797 798 +1
Lines 30027 30033 +6
Branches 5027 5030 +3
==============================================
- Hits 21049 21028 -21
- Misses 7590 7607 +17
- Partials 1388 1398 +10
🚀 New features to boost your workflow:
|
0xnm
approved these changes
Mar 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Ensure consistent trace sampling for all traces in a given session