Skip to content

RUM-7745 update defaults in Tracing configuration#2542

Merged
xgouchet merged 1 commit into
feature/v3from
xgouchet/RUM-7745/update_default_tracing_config
Mar 12, 2025
Merged

RUM-7745 update defaults in Tracing configuration#2542
xgouchet merged 1 commit into
feature/v3from
xgouchet/RUM-7745/update_default_tracing_config

Conversation

@xgouchet

@xgouchet xgouchet commented Mar 12, 2025

Copy link
Copy Markdown
Contributor

What does this PR do?

Update the default configuration for tracing, namely:

  • use SAMPLED instead of ALL as the default TraceContextInjection strategy
  • use 100% instead of 20% for the default network tracing sampling rate

Additional Notes

Renamed the enum constants in TraceContextInjection to be all uppercase

@xgouchet
xgouchet requested review from a team as code owners March 12, 2025 12:54
@xgouchet
xgouchet changed the base branch from develop to feature/v3 March 12, 2025 12:55
ambushwork
ambushwork approved these changes Mar 12, 2025
View reviewed changes

@ambushwork ambushwork left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter

codecov-commenter commented Mar 12, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 53.84615% with 6 lines in your changes missing coverage. Please review.

Project coverage is 70.05%. Comparing base (4bcd7dd) to head (561ac6f).
Report is 2 commits behind head on feature/v3.

Files with missing lines Patch % Lines
...n/com/datadog/android/okhttp/DatadogInterceptor.kt 0.00% 3 Missing ⚠️
...datadog/android/okhttp/trace/TracingInterceptor.kt 62.50% 3 Missing ⚠️
Additional details and impacted files 
@@              Coverage Diff               @@
##           feature/v3    #2542      +/-   ##
==============================================
- Coverage       70.22%   70.05%   -0.17%     
==============================================
  Files             797      797              
  Lines           30025    30027       +2     
  Branches         5027     5027              
==============================================
- Hits            21084    21034      -50     
- Misses           7572     7594      +22     
- Partials         1369     1399      +30
Files with missing lines Coverage Δ
...om/datadog/android/okhttp/TraceContextInjection.kt 100.00% <100.00%> (ø)
...n/com/datadog/android/okhttp/DatadogInterceptor.kt 59.56% <0.00%> (ø)
...datadog/android/okhttp/trace/TracingInterceptor.kt 74.93% <62.50%> (-0.14%) ⬇️

... and 32 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@xgouchet
xgouchet merged commit f2b505a into feature/v3 Mar 12, 2025
@xgouchet
xgouchet deleted the xgouchet/RUM-7745/update_default_tracing_config branch March 12, 2025 14:00
@komoken-dd komoken-dd mentioned this pull request Mar 31, 2026
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xnm 0xnm 0xnm approved these changes
@ambushwork ambushwork ambushwork approved these changes
@jonathanmos jonathanmos jonathanmos approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@xgouchet @codecov-commenter @0xnm @ambushwork @jonathanmos