RUM-3900: Remove RUM feature check in AndroidTracer builder#2539
Merged
aleksandr-gringauz merged 1 commit intoMar 10, 2025
Merged
Conversation
aleksandr-gringauz
force-pushed
the
aleksandr-gringauz/rum-3900/remove-rum-feature-check
branch
from
March 10, 2025 13:19
934fefc to
9106ea5
Compare
| .build() | ||
| ) | ||
|
|
||
| val rumConfig = createRumConfiguration() |
Contributor
Author
There was a problem hiding this comment.
Moved it here in order to test that initializing Rum after AndroidTracer actually works. Also checked that session replay works.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2539 +/- ##
===========================================
+ Coverage 70.04% 70.04% +0.01%
===========================================
Files 797 797
Lines 29990 30025 +35
Branches 5016 5027 +11
===========================================
+ Hits 21004 21031 +27
- Misses 7595 7596 +1
- Partials 1391 1398 +7
🚀 New features to boost your workflow:
|
aleksandr-gringauz
marked this pull request as ready for review
March 10, 2025 13:51
ambushwork
approved these changes
Mar 10, 2025
0xnm
approved these changes
Mar 10, 2025
aleksandr-gringauz
deleted the
aleksandr-gringauz/rum-3900/remove-rum-feature-check
branch
March 10, 2025 14:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The
setBundleWithRumEnabledfeature ofAndroidTracerworks fine even ifRumfeature is initialized afterAndroidTracer.Builder.build()is called. So we remove the warning log and don't setbundleWithRumEnabledtofalseifRumfeature is not initialized whenbuild()is called.demo [internal]:
Here is the link to the session where
Rum.enable(rumConfig)was called right afterAndroidTracer.Builder().build(). I opened "Opentracing traces" screen and tapped "start" on an async operation.Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)