Remove double computation of the RUM payload#2528
Merged
0xnm merged 1 commit intoMar 10, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2528 +/- ##
===========================================
- Coverage 70.08% 70.05% -0.03%
===========================================
Files 797 797
Lines 29990 29988 -2
Branches 5018 5015 -3
===========================================
- Hits 21017 21007 -10
- Misses 7578 7587 +9
+ Partials 1395 1394 -1
🚀 New features to boost your workflow:
|
xgouchet
approved these changes
Mar 10, 2025
jonathanmos
approved these changes
Mar 10, 2025
0xnm
deleted the
nogorodnikov/remove-double-body-computation-in-rum-upload
branch
March 10, 2025 08:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
With https://github.com/DataDog/dd-sdk-android/pull/2298/files#diff-f064e155f59f2de7bfba9d1771f4f6721c48ba34cc1247e8cca065129dedf51b the double computation of the RUM upload body was added, but in fact
MessageDigest.digest(->MessageDigest.updateunder the hood) doesn't mutate input data, so it is safe to use it even after calling this method.Review checklist (to be filled by reviewers)