fix: Allow first build complete to be any number format#2527
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2527 +/- ##
===========================================
- Coverage 70.07% 70.05% -0.03%
===========================================
Files 796 796
Lines 29970 29972 +2
Branches 5016 5013 -3
===========================================
- Hits 21001 20994 -7
- Misses 7574 7584 +10
+ Partials 1395 1394 -1
🚀 New features to boost your workflow:
|
0xnm
approved these changes
Mar 7, 2025
ambushwork
approved these changes
Mar 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Allow the Flutter First Build Complete vital to be any numeric type, then convert it to long when creating the Performance structure.
Motivation
Flutter will truncate Longs down to Ints if they are below a certain value, which was causing the
as? Longcast to failAdditional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)