Skip to content

chore: Set the local-ci script to check for specific version of KTLint#2526

Merged
fuzzybinary merged 1 commit into
developfrom
jward/local-ci-update
Mar 10, 2025
Merged

chore: Set the local-ci script to check for specific version of KTLint#2526
fuzzybinary merged 1 commit into
developfrom
jward/local-ci-update

Conversation

@fuzzybinary

Copy link
Copy Markdown
Member

What does this PR do?

Makes ./local-ci.sh --setup check for a specific version of KTLint instead of just outputting your current version. Also ask if you want to upgrade detekt after printing the current version.

Motivation

Older / incorrect versions of KTLint will clash with what's on CI, giving fewer or more errors than what CI.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@fuzzybinary
fuzzybinary requested review from a team as code owners March 6, 2025 14:00
@codecov-commenter

codecov-commenter commented Mar 6, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.12%. Comparing base (146a8c9) to head (2018601).
Report is 20 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2526      +/-   ##
===========================================
+ Coverage    70.09%   70.12%   +0.03%     
===========================================
  Files          796      796              
  Lines        29957    29959       +2     
  Branches      5012     5009       -3     
===========================================
+ Hits         20997    21006       +9     
+ Misses        7569     7563       -6     
+ Partials      1391     1390       -1     

see 27 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fuzzybinary
fuzzybinary merged commit 6fe5b3b into develop Mar 10, 2025
@fuzzybinary
fuzzybinary deleted the jward/local-ci-update branch March 10, 2025 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants