Skip to content

Catch Coroutines errors while getting all threads stacktraces#2522

Merged
0xnm merged 1 commit into
developfrom
nogorodnikov/catch-coroutines-errors-while-getting-all-stacktraces
Mar 4, 2025
Merged

Catch Coroutines errors while getting all threads stacktraces#2522
0xnm merged 1 commit into
developfrom
nogorodnikov/catch-coroutines-errors-while-getting-all-stacktraces

Conversation

@0xnm

@0xnm 0xnm commented Mar 4, 2025

Copy link
Copy Markdown
Member

What does this PR do?

It seems the Kotlin Coroutines machinery can throw Error sometimes while getting all threads stacktraces. In this PR we will catch them, so that we don't interrupt the flow.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm
0xnm requested review from a team as code owners March 4, 2025 11:17
@codecov-commenter

codecov-commenter commented Mar 4, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 70.04%. Comparing base (30755a2) to head (e083530).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
.../android/error/internal/DatadogExceptionHandler.kt 0.00% 2 Missing ⚠️
...og/android/rum/internal/anr/ANRDetectorRunnable.kt 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2522      +/-   ##
===========================================
+ Coverage    70.00%   70.04%   +0.05%     
===========================================
  Files          796      796              
  Lines        29929    29931       +2     
  Branches      5000     4997       -3     
===========================================
+ Hits         20950    20965      +15     
+ Misses        7587     7580       -7     
+ Partials      1392     1386       -6     
Files with missing lines Coverage Δ
.../android/error/internal/DatadogExceptionHandler.kt 87.67% <0.00%> (ø)
...og/android/rum/internal/anr/ANRDetectorRunnable.kt 81.82% <0.00%> (ø)

... and 33 files with indirect coverage changes

@0xnm
0xnm merged commit bd9c656 into develop Mar 4, 2025
@0xnm
0xnm deleted the nogorodnikov/catch-coroutines-errors-while-getting-all-stacktraces branch March 4, 2025 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants