RUM-8546: Support Flutter's FBC and custom INV values#2520
Merged
Conversation
Both Flutter's "First Build Complete" (FBC) and "Interaction to Next View" (INV) timings are sent as "internal view attributes" which are kept separate from other attributes. Sending view updates pulls these internal attributes and puts them in the proper locations on the RUMViewEvent This PR also offers a way to disable INV, so that Flutter can disable its calculation in favor of its own.
0xnm
requested changes
Mar 4, 2025
| * @param lastInteractionIdentifier the [LastInteractionIdentifier] to use. | ||
| */ | ||
| fun setLastInteractionIdentifier(lastInteractionIdentifier: LastInteractionIdentifier): Builder { | ||
| fun setLastInteractionIdentifier(lastInteractionIdentifier: LastInteractionIdentifier?): Builder { |
Member
There was a problem hiding this comment.
This is a change in the existing public API, not breaking though. I believe we now allow null to disable identifier? Was using no-op implementation instead of null considered?
We probably need to add an explanation what null value does in the doc.
Co-authored-by: Nikita Ogorodnikov <[email protected]>
0xnm
reviewed
Mar 4, 2025
fuzzybinary
force-pushed
the
jward/RUM-8546-first-build-complete
branch
from
March 4, 2025 16:13
0b66000 to
9754a1c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2520 +/- ##
===========================================
+ Coverage 70.00% 70.05% +0.05%
===========================================
Files 796 796
Lines 29929 29957 +28
Branches 5000 5012 +12
===========================================
+ Hits 20950 20986 +36
+ Misses 7587 7576 -11
- Partials 1392 1395 +3
|
0xnm
previously approved these changes
Mar 4, 2025
…d/rum/RumConfiguration.kt Co-authored-by: Nikita Ogorodnikov <[email protected]>
0xnm
approved these changes
Mar 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Both Flutter's "First Build Complete" (FBC) and "Interaction to Next View" (INV) timings are sent as "internal view attributes" which are kept separate from other attributes. Sending view updates pulls these internal attributes and puts them in the proper locations on the RUMViewEvent
This PR also offers a way to disable INV, so that Flutter can disable its calculation in favor of its own.
Review checklist (to be filled by reviewers)