RUM-8038: Improvements to the upload mechanism#2514
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2514 +/- ##
===========================================
+ Coverage 69.95% 70.03% +0.08%
===========================================
Files 794 794
Lines 29873 29873
Branches 4994 4991 -3
===========================================
+ Hits 20897 20920 +23
+ Misses 7588 7570 -18
+ Partials 1388 1383 -5
|
jonathanmos
marked this pull request as ready for review
March 3, 2025 11:28
ambushwork
approved these changes
Mar 3, 2025
0xnm
approved these changes
Mar 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Part of the effort to reduce batch loss.
The improvements implemented here:
• Doubling the average batch processing level, so that instead of an average 10 uploads (10 batches) per upload trigger, it will now be 20.
• Reducing the backoff to the minimum when an upload has succeeded, instead of the previous behavior where we gradually reduced by 10% until we reached the minimum.
Motivation
Faster recovery from offline periods.
Review checklist (to be filled by reviewers)