RUM-8729 ensure span logs use 128 bits trace id as hex string#2512
Merged
Conversation
jonathanmos
previously approved these changes
Feb 24, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2512 +/- ##
===========================================
+ Coverage 69.95% 70.02% +0.07%
===========================================
Files 794 794
Lines 29873 29873
Branches 4994 4994
===========================================
+ Hits 20896 20916 +20
+ Misses 7589 7578 -11
+ Partials 1388 1379 -9
|
xgouchet
force-pushed
the
xgouchet/RUM-8729/span_logs
branch
from
February 24, 2025 13:02
3330643 to
a8654e9
Compare
xgouchet
force-pushed
the
xgouchet/RUM-8729/span_logs
branch
from
February 24, 2025 13:49
a8654e9 to
ab8b849
Compare
jonathanmos
approved these changes
Feb 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Ensures that the logs created from a
DDSpan.log()behave the same way as the ones created from ourLoggerwithbundleWithTrace=true.