RUM-8705: Change UploadWorker visibility from internal to public#2511
Merged
Conversation
ambushwork
force-pushed
the
yl/ih/change-upload-worker-visibility
branch
from
February 21, 2025 10:53
8cb850e to
3f6b4bb
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2511 +/- ##
===========================================
+ Coverage 70.00% 70.04% +0.04%
===========================================
Files 794 794
Lines 29873 29875 +2
Branches 4994 4991 -3
===========================================
+ Hits 20911 20925 +14
+ Misses 7582 7567 -15
- Partials 1380 1383 +3
|
ambushwork
marked this pull request as ready for review
February 21, 2025 11:29
xgouchet
approved these changes
Feb 24, 2025
jonathanmos
approved these changes
Feb 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
change UploadWorker from internal to public
Add doc to warn client that it should only be used in custom workfactory case
Motivation
Fixes #2508
RUM-8705
Review checklist (to be filled by reviewers)