RUM-8349: Add support for detekt checks for session replay compose module#2507
Merged
Conversation
ambushwork
force-pushed
the
yl/fix-detekt-modifier
branch
2 times, most recently
from
February 18, 2025 12:51
a25b286 to
c8c02ca
Compare
ambushwork
force-pushed
the
yl/fix-detekt-modifier
branch
from
February 18, 2025 13:48
c8c02ca to
29548cc
Compare
ambushwork
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2507 +/- ##
===========================================
- Coverage 69.99% 69.98% -0.01%
===========================================
Files 794 794
Lines 29875 29875
Branches 4991 4991
===========================================
- Hits 20911 20907 -4
+ Misses 7584 7582 -2
- Partials 1380 1386 +6 |
ambushwork
marked this pull request as ready for review
February 18, 2025 14:23
jonathanmos
approved these changes
Feb 19, 2025
satween
self-requested a review
February 19, 2025 14:48
satween
approved these changes
Feb 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
dd-sdk-android-session-replay-composein gitlab-ci.ymlMotivation
RUM-8349
Review checklist (to be filled by reviewers)