Skip to content

[RUM-8449] Fixing sampling rate#2503

Merged
satween merged 3 commits into
developfrom
tvaleev/rum-8449/fix-sampling-rate
Feb 6, 2025
Merged

[RUM-8449] Fixing sampling rate#2503
satween merged 3 commits into
developfrom
tvaleev/rum-8449/fix-sampling-rate

Conversation

@satween

@satween satween commented Feb 6, 2025

Copy link
Copy Markdown
Contributor

What does this PR do?

Wrong sampling rate for INV and TNS telemetry was introduced in #2495
Fixing in this ticket.
Also fixing some missing review comments

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@satween
satween requested review from a team as code owners February 6, 2025 15:54
@codecov-commenter

codecov-commenter commented Feb 6, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.04%. Comparing base (9f85267) to head (c96402f).
Report is 4 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2503      +/-   ##
===========================================
- Coverage    70.08%   70.04%   -0.04%     
===========================================
  Files          791      791              
  Lines        29837    29839       +2     
  Branches      4992     4992              
===========================================
- Hits         20910    20898      -12     
- Misses        7553     7562       +9     
- Partials      1374     1379       +5     
Files with missing lines Coverage Δ
.../android/rum/internal/domain/scope/RumViewScope.kt 95.25% <100.00%> (-0.24%) ⬇️
...d/rum/internal/metric/ViewEndedMetricDispatcher.kt 96.55% <100.00%> (+1.72%) ⬆️

... and 31 files with indirect coverage changes

@satween
satween merged commit d230ca7 into develop Feb 6, 2025
@satween
satween deleted the tvaleev/rum-8449/fix-sampling-rate branch February 6, 2025 17:25
@satween satween changed the title [RUM 8449] Fixing sampling rate [RUM-8449] Fixing sampling rate Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants