Fix flaky test in Head-based sampling test suite#2499
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2499 +/- ##
===========================================
- Coverage 70.10% 70.10% -0.00%
===========================================
Files 791 791
Lines 29808 29808
Branches 4987 4987
===========================================
- Hits 20896 20895 -1
- Misses 7534 7536 +2
+ Partials 1378 1377 -1 |
xgouchet
approved these changes
Feb 3, 2025
jonathanmos
approved these changes
Feb 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes a flaky test related to the fact that OpenTelemetry Span context is using fixed-length identifier for Span ID, unlike
SpanEvent, where leading zeros are dropped.Review checklist (to be filled by reviewers)