RUM-8314 allow disabling 404 span redaction#2496
Merged
Merged
Conversation
0xnm
previously approved these changes
Jan 30, 2025
Comment on lines
+892
to
+898
| /** | ||
| * Set whether network requests returning a 404 status code should have their resource name redacted. | ||
| * In order to reduce the cardinality of resource names in APM, 404 urls are automatically redacted to | ||
| * "404" | ||
| * @param redacted if true, all 404 requests will have a resource name set to "404", else the resource name | ||
| * will be the URL | ||
| */ |
Member
There was a problem hiding this comment.
Suggested change
| /** | |
| * Set whether network requests returning a 404 status code should have their resource name redacted. | |
| * In order to reduce the cardinality of resource names in APM, 404 urls are automatically redacted to | |
| * "404" | |
| * @param redacted if true, all 404 requests will have a resource name set to "404", else the resource name | |
| * will be the URL | |
| */ | |
| /** | |
| * Set whether network requests returning a 404 status code should have their resource name redacted. | |
| * In order to reduce the cardinality of resource names in APM, 404 URLs are automatically redacted to | |
| * "404". | |
| * @param redacted if true, all 404 requests will have a resource name set to "404", else the resource name | |
| * will be the URL | |
| */ |
| * @param redacted if true, all 404 requests will have a resource name set to "404", else the resource name | ||
| * will be the URL | ||
| */ | ||
| fun set404ResourcesRedacted(redacted: Boolean): R { |
Member
There was a problem hiding this comment.
side thought: This API may be confusing for DatadogInterceptor users, because this option applies only to APM actually, but they may think that they will see RUM Resource name as "404". But since it is a shared builder, we cannot remove this method from Builder for DatadogInterceptor.
xgouchet
force-pushed
the
xgouchet/RUM-8314/unredact_404
branch
2 times, most recently
from
January 30, 2025 19:14
38da1db to
f82e09e
Compare
xgouchet
force-pushed
the
xgouchet/RUM-8314/unredact_404
branch
from
January 31, 2025 11:15
f82e09e to
021b813
Compare
xgouchet
force-pushed
the
xgouchet/RUM-8314/unredact_404
branch
from
January 31, 2025 11:33
021b813 to
6a01d80
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2496 +/- ##
===========================================
- Coverage 69.95% 69.93% -0.02%
===========================================
Files 788 788
Lines 29647 29660 +13
Branches 4962 4962
===========================================
+ Hits 20739 20742 +3
- Misses 7536 7538 +2
- Partials 1372 1380 +8
|
0xnm
approved these changes
Feb 3, 2025
jonathanmos
approved these changes
Feb 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds an option to keep the resource name for network requests ending in
404as original, instead of having them redacted to"404".