Include Java API surface file in the API changes check#2493
Merged
0xnm merged 1 commit intoJan 27, 2025
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2493 +/- ##
===========================================
- Coverage 70.01% 69.91% -0.10%
===========================================
Files 788 788
Lines 29646 29646
Branches 4962 4962
===========================================
- Hits 20755 20726 -29
- Misses 7520 7552 +32
+ Partials 1371 1368 -3 |
jonathanmos
approved these changes
Jan 27, 2025
0xnm
deleted the
nogorodnikov/include-java-api-surface-file-in-changes-check
branch
January 27, 2025 13:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
We were checking only Kotlin API surface file for the missing changes, this PR adds Java API surface file.
Review checklist (to be filled by reviewers)