Adjust telemetry metrics sampling rates#2490
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2490 +/- ##
===========================================
+ Coverage 69.88% 69.97% +0.09%
===========================================
Files 788 788
Lines 29647 29647
Branches 4961 4961
===========================================
+ Hits 20717 20745 +28
+ Misses 7548 7526 -22
+ Partials 1382 1376 -6
|
| internalLogger.logMetric( | ||
| messageBuilder = { BATCH_DELETED_MESSAGE }, | ||
| additionalProperties = it, | ||
| samplingRate = MethodCallSamplingRate.LOW.rate |
There was a problem hiding this comment.
this will increase the volume by 15x times, is it expected?
There was a problem hiding this comment.
Yep, this is to align with iOS metrics
There was a problem hiding this comment.
By looking on the volume for the "Batch Closed" telemetry for the latest SDK releases (2.17.0 for Android, 2.22.0 for iOS) the difference is like 8x, but only 3x for the 2.16.0 vs 2.21.0, so probably increasing this by 15x will create big disparity (and maybe this value should be lowered on iOS?), but if the goal is to have the same effective sampling rate between the 2 platforms, I'm fine with this change.
| messageBuilder = { BATCH_DELETED_MESSAGE }, | ||
| additionalProperties = it, | ||
| samplingRate = MethodCallSamplingRate.LOW.rate | ||
| samplingRate = 1.5f |
There was a problem hiding this comment.
For the other sampling rates we've used values from MethodCallSamplingRate. Do we not want to add an additional value there for this rate (do we not expect 1.5f to be reused)?
4 participants
What does this PR do?
Adjust the metrics sampling rate, to ensure we have consistent data across platforms, and don't overwhelm our intake.