Skip to content

RUM-8141: Add OpenTracing API as exported dependency to OkHttp instrumentation#2488

Merged
0xnm merged 1 commit into
developfrom
nogorodnikov/rum-8141/add-opentracing-api-as-api-dependency-to-okhttp-instrumentation
Jan 20, 2025
Merged

RUM-8141: Add OpenTracing API as exported dependency to OkHttp instrumentation#2488
0xnm merged 1 commit into
developfrom
nogorodnikov/rum-8141/add-opentracing-api-as-api-dependency-to-okhttp-instrumentation

Conversation

@0xnm

@0xnm 0xnm commented Jan 17, 2025

Copy link
Copy Markdown
Member

What does this PR do?

Fixes #2486, check for more details there.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm
0xnm requested review from a team as code owners January 17, 2025 15:28
@0xnm
0xnm force-pushed the nogorodnikov/rum-8141/add-opentracing-api-as-api-dependency-to-okhttp-instrumentation branch from b447582 to 80099c4 Compare January 17, 2025 15:39
@codecov-commenter

codecov-commenter commented Jan 17, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.97%. Comparing base (58f27a4) to head (80099c4).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2488      +/-   ##
===========================================
+ Coverage    69.88%   69.97%   +0.09%     
===========================================
  Files          788      788              
  Lines        29647    29647              
  Branches      4961     4961              
===========================================
+ Hits         20717    20744      +27     
+ Misses        7548     7526      -22     
+ Partials      1382     1377       -5     

see 33 files with indirect coverage changes

@0xnm
0xnm merged commit 1424c51 into develop Jan 20, 2025
@0xnm
0xnm deleted the nogorodnikov/rum-8141/add-opentracing-api-as-api-dependency-to-okhttp-instrumentation branch January 20, 2025 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dd-sdk-android-okhttp artifact explicitly mentions io.opentracing.Span in the api, but does not declare the dep in the maven/gradle metadata

4 participants