Fix _dd.rule_psr attribute calculation for RUM#2485
Merged
0xnm merged 1 commit intoJan 15, 2025
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2485 +/- ##
===========================================
+ Coverage 69.95% 70.01% +0.06%
===========================================
Files 788 788
Lines 29605 29604 -1
Branches 4943 4944 +1
===========================================
+ Hits 20709 20725 +16
+ Misses 7524 7515 -9
+ Partials 1372 1364 -8
|
jonathanmos
approved these changes
Jan 15, 2025
0xnm
deleted the
nogorodnikov/fix-rule-psr-calculation-in-rum-attributes
branch
January 15, 2025 09:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This attribute should be in the range
[0;1], but Sampler#getSampleRate returns a value in the range[0;100], so we need to normalize.Review checklist (to be filled by reviewers)