Skip to content

Update enums to match RUM event schema#2482

Merged
xgouchet merged 1 commit into
developfrom
xgouchet/missing_rum_enum_constants
Jan 13, 2025
Merged

Update enums to match RUM event schema#2482
xgouchet merged 1 commit into
developfrom
xgouchet/missing_rum_enum_constants

Conversation

@xgouchet

Copy link
Copy Markdown
Contributor

What does this PR do?

Update the enums we use in our API to match some constants available in the RUM schema

Motivation

Ensure a better consistency across platforms.

@xgouchet
xgouchet requested review from a team as code owners January 13, 2025 09:55
@xgouchet
xgouchet force-pushed the xgouchet/missing_rum_enum_constants branch from 24dd35a to 00b9ef7 Compare January 13, 2025 11:59
@codecov-commenter

codecov-commenter commented Jan 13, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 96.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 70.04%. Comparing base (3adfe60) to head (00b9ef7).
Report is 37 commits behind head on develop.

Files with missing lines Patch % Lines
...trace/internal/domain/event/BaseSpanEventMapper.kt 66.67% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2482      +/-   ##
===========================================
+ Coverage    69.92%   70.04%   +0.12%     
===========================================
  Files          786      786              
  Lines        29301    29406     +105     
  Branches      4889     4902      +13     
===========================================
+ Hits         20486    20596     +110     
- Misses        7442     7455      +13     
+ Partials      1373     1355      -18     
Files with missing lines Coverage Δ
...tlin/com/datadog/android/api/context/DeviceType.kt 100.00% <100.00%> (ø)
...n/kotlin/com/datadog/android/rum/RumErrorSource.kt 100.00% <100.00%> (ø)
...g/android/rum/internal/domain/scope/RumEventExt.kt 93.77% <100.00%> (+0.26%) ⬆️
...trace/internal/domain/event/BaseSpanEventMapper.kt 94.59% <66.67%> (+11.74%) ⬆️

... and 40 files with indirect coverage changes

@xgouchet
xgouchet merged commit 54a38b6 into develop Jan 13, 2025
@xgouchet
xgouchet deleted the xgouchet/missing_rum_enum_constants branch January 13, 2025 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants