RUM-7809: Update SDK performance doc with Session Replay measurements#2481
Merged
Conversation
ambushwork
force-pushed
the
yl/sr/update-perf-doc
branch
2 times, most recently
from
January 10, 2025 10:22
92979f8 to
1b91414
Compare
ambushwork
marked this pull request as ready for review
January 10, 2025 10:25
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2481 +/- ##
==========================================
Coverage ? 69.98%
==========================================
Files ? 788
Lines ? 29559
Branches ? 4935
==========================================
Hits ? 20686
Misses ? 7508
Partials ? 1365 |
satween
previously approved these changes
Jan 10, 2025
brett0000FF
previously approved these changes
Jan 10, 2025
brett0000FF
left a comment
brett0000FF
left a comment
There was a problem hiding this comment.
I did a light courtesy edit on the new content. Feel free to take what you'd like. 😄
| CPU and Memory profiling was done for the `debug` build type . CPU profiling was done using | ||
| the `System Traces` option. | ||
|
|
||
| ### Scenario corresponding |
There was a problem hiding this comment.
Suggested change
| ### Scenario corresponding | |
| ### Scenario configuration |
jonathanmos
previously approved these changes
Jan 13, 2025
xgouchet
previously approved these changes
Jan 13, 2025
ambushwork
dismissed stale reviews from xgouchet, jonathanmos, brett0000FF, and satween
via
February 6, 2025 10:57
94806bb
ambushwork
force-pushed
the
yl/sr/update-perf-doc
branch
from
February 6, 2025 10:57
1b91414 to
94806bb
Compare
Member
Author
|
@brett0000FF thanks for the review, I've updated the doc based on your comment! |
brett0000FF
approved these changes
Feb 6, 2025
xgouchet
approved these changes
Feb 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
A brief description of the change being made with this pull request.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)