RUM-7472: Fix center crop image is not cropped in wireframe#2479
Merged
Conversation
ambushwork
force-pushed
the
yl/sr/fix-image-scale
branch
2 times, most recently
from
January 8, 2025 16:46
98aa44d to
381313d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2479 +/- ##
===========================================
+ Coverage 69.87% 70.00% +0.13%
===========================================
Files 788 788
Lines 29536 29536
Branches 4926 4929 +3
===========================================
+ Hits 20636 20674 +38
+ Misses 7528 7507 -21
+ Partials 1372 1355 -17
|
ambushwork
force-pushed
the
yl/sr/fix-image-scale
branch
from
January 9, 2025 13:58
381313d to
4b9d3b3
Compare
ambushwork
marked this pull request as ready for review
January 9, 2025 15:08
0xnm
approved these changes
Jan 9, 2025
jonathanmos
approved these changes
Jan 9, 2025
xgouchet
approved these changes
Jan 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The bug is introduced by this PR, it fixed the padding issue when cropping the image, but it broke the clip for center crop image when it has cropToPadding as false.
This PR is to fix the problem by differentiate the parent content size by
cropToPaddingattribute, so the clip wireframe can be applied anyway.Motivation
Demo
Review checklist (to be filled by reviewers)