Skip to content

RUM-7116: Add RadioButton color#2478

Merged
jonathanmos merged 1 commit into
developfrom
jmoskovich/rum-7116/radiobutton-colors
Jan 12, 2025
Merged

RUM-7116: Add RadioButton color#2478
jonathanmos merged 1 commit into
developfrom
jmoskovich/rum-7116/radiobutton-colors

Conversation

@jonathanmos

@jonathanmos jonathanmos commented Jan 8, 2025

Copy link
Copy Markdown
Member

What does this PR do?

Adds the correct Jetpack Compose RadioButton color to the mapper. Also adds masking support for RadioButton since it was not part of the original pr that added RadioButton support.

Motivation

Part of the support for Jetpack Compose.

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@codecov-commenter

codecov-commenter commented Jan 8, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 72.34043% with 13 lines in your changes missing coverage. Please review.

Project coverage is 69.89%. Comparing base (cad0d62) to head (67331c3).
Report is 4 commits behind head on develop.

Files with missing lines Patch % Lines
...l/mappers/semantics/CheckboxSemanticsNodeMapper.kt 37.50% 3 Missing and 2 partials ⚠️
...y/compose/internal/reflection/ComposeReflection.kt 0.00% 4 Missing ⚠️
...appers/semantics/RadioButtonSemanticsNodeMapper.kt 86.36% 1 Missing and 2 partials ⚠️
...onreplay/compose/internal/utils/ReflectionUtils.kt 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #2478      +/-   ##
===========================================
- Coverage    69.91%   69.89%   -0.02%     
===========================================
  Files          788      788              
  Lines        29560    29587      +27     
  Branches      4932     4940       +8     
===========================================
+ Hits         20665    20679      +14     
- Misses        7521     7540      +19     
+ Partials      1374     1368       -6
Files with missing lines Coverage Δ
...nal/mappers/semantics/SwitchSemanticsNodeMapper.kt 94.74% <ø> (ø)
...ionreplay/compose/internal/utils/SemanticsUtils.kt 71.35% <100.00%> (+0.86%) ⬆️
...onreplay/compose/internal/utils/ReflectionUtils.kt 1.79% <0.00%> (-0.03%) ⬇️
...appers/semantics/RadioButtonSemanticsNodeMapper.kt 90.91% <86.36%> (+1.17%) ⬆️
...y/compose/internal/reflection/ComposeReflection.kt 0.00% <0.00%> (ø)
...l/mappers/semantics/CheckboxSemanticsNodeMapper.kt 93.80% <37.50%> (-3.03%) ⬇️

... and 30 files with indirect coverage changes

@jonathanmos
jonathanmos marked this pull request as ready for review January 8, 2025 12:14
@jonathanmos
jonathanmos requested review from a team as code owners January 8, 2025 12:14
0xnm
0xnm approved these changes Jan 9, 2025
View reviewed changes
Comment thread ...in/kotlin/com/datadog/android/sessionreplay/compose/internal/reflection/ComposeReflection.kt
Comment thread ...e/src/main/kotlin/com/datadog/android/sessionreplay/compose/internal/utils/SemanticsUtils.kt Outdated
Comment thread ...droid/sessionreplay/compose/internal/mappers/semantics/RadioButtonSemanticsNodeMapperTest.kt
@jonathanmos
jonathanmos force-pushed the jmoskovich/rum-7116/radiobutton-colors branch 3 times, most recently from e813137 to d8dd9a4 Compare January 9, 2025 14:19
@jonathanmos
jonathanmos force-pushed the jmoskovich/rum-7116/radiobutton-colors branch from d8dd9a4 to 67331c3 Compare January 12, 2025 09:59
@jonathanmos
jonathanmos merged commit 2cf290c into develop Jan 12, 2025
@jonathanmos
jonathanmos deleted the jmoskovich/rum-7116/radiobutton-colors branch January 12, 2025 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xnm 0xnm 0xnm approved these changes
+1 more reviewer
@xgouchet xgouchet xgouchet approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jonathanmos @codecov-commenter @xgouchet @0xnm