RUM-7467: Apply contrasting color to semantics component#2477
Merged
Conversation
ambushwork
force-pushed
the
yl/compose/contrast-color
branch
2 times, most recently
from
January 8, 2025 15:28
d52731c to
30f4ecd
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2477 +/- ##
===========================================
+ Coverage 69.87% 69.99% +0.13%
===========================================
Files 788 788
Lines 29536 29560 +24
Branches 4926 4932 +6
===========================================
+ Hits 20636 20690 +54
+ Misses 7528 7505 -23
+ Partials 1372 1365 -7
|
ambushwork
marked this pull request as ready for review
January 8, 2025 16:43
0xnm
reviewed
Jan 8, 2025
ambushwork
force-pushed
the
yl/compose/contrast-color
branch
from
January 9, 2025 07:54
30f4ecd to
26f455a
Compare
xgouchet
approved these changes
Jan 9, 2025
0xnm
approved these changes
Jan 9, 2025
jonathanmos
approved these changes
Jan 9, 2025
ambushwork
force-pushed
the
yl/compose/contrast-color
branch
from
January 9, 2025 12:39
26f455a to
6140c91
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In semantics tree we are not able to retrieve the complex color of some components including:
Therefore we need to assume a contrasting color based on the background color to make them as much visible as possible.
The core function judges if the background is a bright one or dark one by Luma forumla , based on that, we can give the content a black color or white color.
Demo
The components turn white in dark mode:
Review checklist (to be filled by reviewers)