RUM-7870: Remove non-critical Compose reflection error from telemetry#2476
Merged
Conversation
ambushwork
force-pushed
the
yl/compose/clean-telementry
branch
from
January 3, 2025 14:41
4fbbf32 to
8b94d73
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2476 +/- ##
===========================================
+ Coverage 69.88% 69.88% +0.01%
===========================================
Files 787 787
Lines 29435 29469 +34
Branches 4909 4920 +11
===========================================
+ Hits 20568 20594 +26
- Misses 7495 7514 +19
+ Partials 1372 1361 -11
|
ambushwork
marked this pull request as ready for review
January 3, 2025 15:04
0xnm
approved these changes
Jan 3, 2025
jonathanmos
approved these changes
Jan 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In Compose Session Replay, we setup some telemetry to monitor if the reflection is broken on client side, in the current version we noticed that some telemetries are false alert, so we need to remove them.
In this PR, we remove following reflection telemetry:
Motivation
RUM-7870
Review checklist (to be filled by reviewers)