RUM-6199: Add Semantics mapper for Switch#2471
Merged
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2471 +/- ##
===========================================
+ Coverage 69.91% 70.03% +0.13%
===========================================
Files 787 788 +1
Lines 29347 29501 +154
Branches 4895 4914 +19
===========================================
+ Hits 20516 20661 +145
- Misses 7470 7477 +7
- Partials 1361 1363 +2
|
jonathanmos
marked this pull request as ready for review
January 5, 2025 08:58
jonathanmos
force-pushed
the
jmoskovich/RUM-6199/compose-switch
branch
from
January 5, 2025 17:46
13d8e55 to
533dc30
Compare
ambushwork
approved these changes
Jan 6, 2025
jonathanmos
force-pushed
the
jmoskovich/RUM-6199/compose-switch
branch
from
January 6, 2025 12:21
533dc30 to
462c269
Compare
0xnm
approved these changes
Jan 7, 2025
jonathanmos
force-pushed
the
jmoskovich/RUM-6199/compose-switch
branch
from
January 7, 2025 10:02
462c269 to
c9d5572
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds support for the Compose Switch component. For the masked state returns an empty track, for the off state returns a white thumb on a white track, for the on state returns a black thumb on a black track. These colors are temporary until we can find a way to get the actual colors for the thumb and track.
Masked
Off
On
Motivation
Additional mapper to support Compose.
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)