RUM-7894: Fix proguard rules for compose checkbox#2470
Merged
Conversation
jonathanmos
changed the title
jonathanmos
force-pushed
the
jmoskovich/rum-7894/fix-checkbox-proguard
branch
from
December 30, 2024 16:36
2635b7a to
cc0834b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2470 +/- ##
===========================================
+ Coverage 69.95% 69.96% +0.01%
===========================================
Files 786 786
Lines 29298 29299 +1
Branches 4889 4891 +2
===========================================
+ Hits 20493 20497 +4
+ Misses 7439 7435 -4
- Partials 1366 1367 +1 |
jonathanmos
marked this pull request as ready for review
December 31, 2024 08:27
0xnm
approved these changes
Dec 31, 2024
Member
|
Question about the description "that the path for CheckboxKt should be different." it should be different from what? from debug? |
ambushwork
approved these changes
Dec 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Checkbox is not visible in obfuscated apks. From an investigation it looks like we need to use
keepoverkeepClassMembers, and also that the class name for CheckboxKt should be changed.Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)