Fix internal telemetry on invalid loading time usage#2468
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2468 +/- ##
===========================================
+ Coverage 69.92% 69.98% +0.07%
===========================================
Files 786 786
Lines 29301 29299 -2
Branches 4889 4891 +2
===========================================
+ Hits 20486 20504 +18
+ Misses 7442 7434 -8
+ Partials 1373 1361 -12
|
jonathanmos
reviewed
Dec 20, 2024
| InternalTelemetryEvent.ApiUsage.AddViewLoadingTime( | ||
| overwrite = event.overwrite, | ||
| noView = hasNoView, | ||
| noActiveView = !hasNoView |
Member
There was a problem hiding this comment.
This is a bit confusing to me. If we get here then it means we're inside a block where hasActiveView is necessarily false, but we could end up passing false to AddViewLoading time for noActiveView indicating that there is actually an active view?
Contributor
Author
There was a problem hiding this comment.
Here I'm replicating the intended usage of this telemetry, where only one of the two attributes can be true at a time.
jonathanmos
approved these changes
Dec 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The way our telemetry was set up, we could send warnings when there shouldn't have been :