Skip to content

RUM-7216: Add Slider semantics node mapper#2459

Merged
ambushwork merged 1 commit into
developfrom
yl/compose/slider-mapper
Dec 31, 2024
Merged

RUM-7216: Add Slider semantics node mapper#2459
ambushwork merged 1 commit into
developfrom
yl/compose/slider-mapper

Conversation

@ambushwork

Copy link
Copy Markdown
Member

What does this PR do?

A brief description of the change being made with this pull request.

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@codecov-commenter

codecov-commenter commented Dec 18, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 25.92593% with 40 lines in your changes missing coverage. Please review.

Project coverage is 69.92%. Comparing base (f61a42c) to head (7bb3cef).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
...nal/mappers/semantics/SliderSemanticsNodeMapper.kt 15.91% 37 Missing ⚠️
...ernal/mappers/semantics/RootSemanticsNodeMapper.kt 77.78% 0 Missing and 2 partials ⚠️
...ionreplay/compose/internal/utils/SemanticsUtils.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2459      +/-   ##
===========================================
- Coverage    69.95%   69.92%   -0.02%     
===========================================
  Files          786      787       +1     
  Lines        29298    29347      +49     
  Branches      4889     4895       +6     
===========================================
+ Hits         20493    20520      +27     
- Misses        7439     7473      +34     
+ Partials      1366     1354      -12     
Files with missing lines Coverage Δ
...ionreplay/compose/internal/utils/SemanticsUtils.kt 75.48% <0.00%> (-0.49%) ⬇️
...ernal/mappers/semantics/RootSemanticsNodeMapper.kt 78.82% <77.78%> (+3.51%) ⬆️
...nal/mappers/semantics/SliderSemanticsNodeMapper.kt 15.91% <15.91%> (ø)

... and 44 files with indirect coverage changes

@ambushwork
ambushwork force-pushed the yl/compose/slider-mapper branch 3 times, most recently from 9215d72 to 0623ff9 Compare December 26, 2024 12:55
@ambushwork
ambushwork marked this pull request as ready for review December 26, 2024 16:08
@ambushwork
ambushwork requested review from a team as code owners December 26, 2024 16:08
@ambushwork
ambushwork force-pushed the yl/compose/slider-mapper branch from 0623ff9 to 6a589b8 Compare December 27, 2024 08:14
@ambushwork
ambushwork requested a review from satween December 27, 2024 08:53
@ambushwork
ambushwork force-pushed the yl/compose/slider-mapper branch from 6a589b8 to 7bb3cef Compare December 30, 2024 13:03
@ambushwork
ambushwork merged commit 94cd709 into develop Dec 31, 2024
@ambushwork
ambushwork deleted the yl/compose/slider-mapper branch December 31, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants